Closed cdjohnson closed 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cdjohnson
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval by writing /assign @joelanford
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@cdjohnson: PR needs rebase.
The
describe
andlist-available
commands made assumptions on an operator existing in only one catalog. It also did not understand namespace-scoped catalogs resulting in incomplete results. It now honors the context namespace as well as the-n
override option to properly detect global vs. namespace-scoped catalogs.I also added additional catalog metadata to the output.
Example output of
describe
when a package exists in two catalogs at the Global and Namespace scopes:Example output of
list-available
when a package exists in two catalogs at the Global and Namespace scopes:Note: I purposely injected the NAMESPACE value into the
list-available
output. Since this is supposed to be a human-readable file, I'm assuming we do not need to preserve backward compatibility. I could add it at the end, but it would be unnatural. If this were to be a machine-readable tool, then I assume we would add a-o json
option.