search

operator-framework / olm-docs

Hugo doc site for https://github.com/operator-framework/operator-lifecycle-manager
10 stars 82 forks source link

doc: add common suggestions #134

Closed camilamacedo86 closed 3 years ago

camilamacedo86 commented 3 years ago

Description Add doc with common suggestions

Motivation

camilamacedo86 commented 3 years ago

Hi @timflannagan,

Thank you for your help. All done.

timflannagan commented 3 years ago

I just set up tide for this repository, but I don't have approval permissions, so you'll need to reach out to someone that does.

/lgtm

timflannagan commented 3 years ago

The linting check can be ignored. It doesn't take into account files that are being introduced, which results in a 404 being displayed. We may need to check why that's happening further down the line.

camilamacedo86 commented 3 years ago

Hi @anik120,

WDYT about this one? Can we get this one merged?

anik120 commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/olm-docs/blob/master/OWNERS)~~ [anik120] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
timflannagan commented 3 years ago

Looks like tide is gated on the test/lint action passing, but I'm almost positive there are some limitations with how tide and github action status are processed. Going to try and override, and that likely won't work, so this is a force-merge candidate.

/override lint

openshift-ci-robot commented 3 years ago

@timflannagan: /override requires a failed status context to operate on. The following unknown contexts were given:

Only the following contexts were expected:

In response to [this](https://github.com/operator-framework/olm-docs/pull/134#issuecomment-804187233): >Looks like tide is gated on the test/lint action passing, but I'm almost positive there are some limitations with how tide and github action status are processed. Going to try and override, and that likely won't work, so this is a force-merge candidate. > >/override lint Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
timflannagan commented 3 years ago

This is likely a bad idea, but :shrug:.

/override tide

openshift-ci-robot commented 3 years ago

@timflannagan: Overrode contexts on behalf of timflannagan: tide

In response to [this](https://github.com/operator-framework/olm-docs/pull/134#issuecomment-804187659): >This is likely a bad idea, but :shrug:. > >/override tide Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
anik120 commented 3 years ago

The linting check can be ignored. It doesn't take into account files that are being introduced, which results in a 404 being displayed. We may need to check why that's happening further down the line.

Merging this one manually