search

operator-framework / olm-docs

Hugo doc site for https://github.com/operator-framework/operator-lifecycle-manager
10 stars 82 forks source link

update the best practices link since the content was moved to sdk #146

Closed camilamacedo86 closed 3 years ago

camilamacedo86 commented 3 years ago

See : https://github.com/operator-framework/community-operators/pull/3491

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86 To complete the pull request process, please assign njhale after the PR has been reviewed. You can assign the PR to them by writing /assign @njhale in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/operator-framework/olm-docs/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
timflannagan commented 3 years ago

Ah man, looks like I didn't set up tide to automatically lgtm on an approved review :cry:

/lgtm

timflannagan commented 3 years ago 
c02a5f3da18c: Pull complete
Digest: sha256:505df5f98139b81fd3563b385134c5a784b58bfc8d5a4ece57fa2cbe58b3144f
Status: Downloaded newer image for mtlynch/htmlproofer:latest
Running ["ImageCheck", "ScriptCheck", "LinkCheck"] on ["/target"] on *.html... 

Checking 141 external links...
- /target/docs/tasks/install-operator-with-olm/index.html
  *  internally linking to channel-def, which does not exist (line 678)
     <a href="channel-def">channel</a>
Ran on 44 files!

/lgtm

timflannagan commented 3 years ago

https://github.com/operator-framework/olm-docs/pull/153 to address the unrelated linting failure.

anik120 commented 3 years ago

/approve /lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/olm-docs/blob/master/OWNERS)~~ [anik120] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment