search

operator-framework / olm-docs

Hugo doc site for https://github.com/operator-framework/operator-lifecycle-manager
10 stars 82 forks source link

rename subscription.spec.approval to .installPlanApproval #152

Closed erdii closed 3 years ago

erdii commented 3 years ago

Heyo OLM folks :wave: :smiley:

According to https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.18.1/crds.yaml the field is named installPlanApproval.

timflannagan commented 3 years ago

Ah, yeah I forgot tide isn't configured in this repository to mark approved reviews as lgtm:

oc explain subscriptions.spec
KIND:     Subscription
VERSION:  operators.coreos.com/v1alpha1

RESOURCE: spec <Object>

DESCRIPTION:
     SubscriptionSpec defines an Application that can be installed

FIELDS:
   channel  <string>

   config   <Object>
     SubscriptionConfig contains configuration specified for a subscription.

   installPlanApproval  <string>
     Approval is the user approval policy for an InstallPlan. It must be one of
     "Automatic" or "Manual".

   name <string> -required-

   source   <string> -required-

   sourceNamespace  <string> -required-

   startingCSV  <string>

/lgtm

erdii commented 3 years ago

Tide also wants the approved label.

Can you /approve?

timflannagan commented 3 years ago

I cannot as I don't have approval permissions in this repository.

/assign @anik120

anik120 commented 3 years ago

/approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, erdii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/olm-docs/blob/master/OWNERS)~~ [anik120] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment