search

operator-framework / olm-docs

Hugo doc site for https://github.com/operator-framework/operator-lifecycle-manager
10 stars 82 forks source link

.github/workflows: Update the lint workflow to checkout the correct commit #176

Closed timflannagan closed 3 years ago

timflannagan commented 3 years ago

Update the .github/workflows/lint.yaml check and ensure that the actions/checkout@v2 step is checking out the correct commit.

It looks like there's an existing bug in the actions/checkout@v2 action such that it's pointing to the wrong commit hash when checking out the repository. This can lead to cases where an action job may fail in a PR, another PR fixes that action, and the first PR still fails as it's checking out the wrong commit hash. Temporary workarounds include rebasing the first PR to pick up the new changes, but this can lead to larger situations where we're not accurately testing changes against an upstream/master remote.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/operator-framework/olm-docs/blob/master/OWNERS)~~ [anik120] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
anik120 commented 3 years ago

@timflannagan looks like this PR needs to be rebased.

timflannagan commented 3 years ago

Closing for now as I'm not convinced this is the right approach anymore.