search

operator-framework / operator-controller

Apache License 2.0
30 stars 47 forks source link

🌱 Remove `kind-redeploy` make target #1004

Open m1kola opened 6 days ago

m1kola commented 6 days ago

Description

This target is broken because OPERATOR_CONTROLLER_NAMESPACE does not exist.

Reviewer Checklist

netlify[bot] commented 6 days ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 98534bf3165e73e7247443b15926e8a9b1dafe9d
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66840d1970c23f00081132c6
Deploy Preview https://deploy-preview-1004--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.19%. Comparing base (872b7f7) to head (98534bf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1004 +/- ## ======================================= Coverage 77.19% 77.19% ======================================= Files 17 17 Lines 1206 1206 ======================================= Hits 931 931 Misses 193 193 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1004/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1004/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.54% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1004/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `51.90% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelanford commented 4 days ago

I noticed this was broken recently as well. But I know @tmshort added it fairly recently, so maybe worth getting his opinion on this PR.

bentito commented 7 hours ago

I noticed this was broken recently as well. But I know @tmshort added it fairly recently, so maybe worth getting his opinion on this PR.

Uh.. it looks like the line got sucked out the airlock in b08a1e92 Should we just put OPERATOR_CONTROLLER_NAMESPACE ?= operator-controller-system and fix the target?