search

operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

✨ Cleaner Condition Types & Reasons #1007

Open bentito opened 6 days ago

bentito commented 6 days ago

Description

Cleaner Condition Types & Reasons. See commit messages for coverage of this PR and its sync to the RFC recommendations. https://docs.google.com/document/d/1JWJxnDXM0X1JQ67ZIDx5j1ayb1d7ajrK_uSDDaz0G98

Reviewer Checklist

netlify[bot] commented 6 days ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit c899a79cef3e260fe28a947a7570a3cd2a538b5e
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/668bd6beec84d1000806abb0
Deploy Preview https://deploy-preview-1007--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (872b7f7) to head (c899a79). Report is 5 commits behind head on main.

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1007 +/- ## ========================================== + Coverage 77.19% 77.91% +0.71% ========================================== Files 17 18 +1 Lines 1206 1245 +39 ========================================== + Hits 931 970 +39 Misses 193 193 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1007/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.44% <0.00%> (-0.10%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.41% <77.77%> (+1.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bentito commented 5 days ago

NB: go-apidiff is an expected failing test as we're intentionally removing API items pre-GA.