operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

✨ Fixes and Improvements for TokenGetter #1014

Closed skattoju closed 3 months ago

skattoju commented 3 months ago

Description

Fixes for some issues that were over looked in #1006 including:

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 019603d64c093b4d3d83d003c9c01696046a3667
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66883837e1150f000859c391
Deploy Preview https://deploy-preview-1014--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.00%. Comparing base (5c83e91) to head (019603d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1014 +/- ## ========================================== - Coverage 78.07% 78.00% -0.08% ========================================== Files 18 18 Lines 1254 1250 -4 ========================================== - Hits 979 975 -4 Misses 193 193 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1014/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.54% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.60% <100.00%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.