search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

✨ [WIP] Add support for kubectl printer columns #1019

Open kevinrizza opened 3 months ago

kevinrizza commented 3 months ago

Adds installed version, resolved version and age printer columns

Resolves https://github.com/operator-framework/operator-controller/issues/1018

Description

Reviewer Checklist

kevinrizza commented 3 months ago

These seem like reasonable printer columns to me, but we should have some agreement that these make the most sense before committing to them. Leaving this as a WIP pr for now.

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 2fd9441e5541913a66c9cd4b2bfebac0ec4ef4bd
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/668c3ec963ac8f0008d7595a
Deploy Preview https://deploy-preview-1019--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.05%. Comparing base (235e3d4) to head (2fd9441).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1019 +/- ## ======================================= Coverage 78.05% 78.05% ======================================= Files 18 18 Lines 1253 1253 ======================================= Hits 978 978 Misses 193 193 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.65% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.47% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kevinrizza commented 3 months ago

@joelanford I looked around and didn't find anything. Imo we should keep this pr held until we make some improvements to the availability of this metadata. I'm also interested in any other thoughts on other columns we might want to have.

tmshort commented 1 month ago

Where are we on this? Keeping it? Does it need rework?