search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

🌱 Move all e2e scripts into one location #1046

Closed m1kola closed 2 months ago

m1kola commented 3 months ago

Description

Follow up for https://github.com/operator-framework/operator-controller/pull/1003#pullrequestreview-2175049874.

Some of the e2e scripts were in ./hack and some were in ./test/tools. Moved everything into single location. Everything is in ./hack/test now.

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit b7462b30106deede722eda03952a934658d3b064
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6698d0fc9801ec000821c0f3
Deploy Preview https://deploy-preview-1046--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.50%. Comparing base (6cd022e) to head (b7462b3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1046 +/- ## ======================================= Coverage 72.50% 72.50% ======================================= Files 32 32 Lines 1884 1884 ======================================= Hits 1366 1366 Misses 383 383 Partials 135 135 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1046/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `55.33% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `44.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmshort commented 3 months ago

I would actually suggest moving from hack into test/tools. hack to me means something completely different...

m1kola commented 3 months ago

I moved it into hack because we use ./hack dir in a few other repos (OLMv0, catalogd, probably more) and it was historically preceding ./test/tools.

But I'm not opposed into getting rid of ./hack and moving everything into ./test/tools. I'll get back to it tomorrow.

perdasilva commented 3 months ago

Just my 2c (nothing blocking), seems the hack directory pattern is a k8s'ism (e.g. https://github.com/kubernetes/kops/issues/444) - seems many go projects copied it. While not against moving to ./test/tools, the hack dir may already be an expectation for many k8s devs in the wild.

As an alternative, we could also move test/tools to /hack/test - and have a hack/misc for more specific purposed, non-critical-path, type scripts.

tmshort commented 2 months ago

I'd be ok with hack/test, it's at least a bit more descriptive... that being said, I really hate the misuse of the term "hack" (e.g. "life hack").

tmshort commented 2 months ago

@m1kola ?

m1kola commented 2 months ago

Sorry, something more urgent/importnat came up and I was focusing on it.

Moved everything into ./hack/test.