search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

:sparkles: Use x509.CertPools instead of PEM strings #1052

Closed tmshort closed 3 months ago

tmshort commented 3 months ago

Fixes #999

Description

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 8c148f26dd2f9d924cb349fc2b573d7cca07a645
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66957c8103a6d4000815e001
Deploy Preview https://deploy-preview-1052--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (bfc65ee) to head (8c148f2).

Files Patch % Lines
internal/httputil/httputil.go 50.00% 10 Missing and 6 partials :warning:
cmd/manager/main.go 57.14% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1052 +/- ## ========================================== - Coverage 72.98% 72.63% -0.36% ========================================== Files 28 28 Lines 1877 1889 +12 ========================================== + Hits 1370 1372 +2 - Misses 375 381 +6 - Partials 132 136 +4 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1052/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1052/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.19% <56.81%> (-0.15%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1052/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `45.36% <6.81%> (-0.56%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.