search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

:bug: Separate make fix-lint from make vet #1054

Closed tmshort closed 3 months ago

tmshort commented 3 months ago

Fixes a downstreaming issue.

Description

Reviewer Checklist

tmshort commented 3 months ago

ping @perdasilva

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 2856cfa34dec118f7f9f88bd62b0a3aae188d4d8
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6695e2a14f9d3100088aa607
Deploy Preview https://deploy-preview-1054--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.63%. Comparing base (87d97f2) to head (2856cfa).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1054 +/- ## ======================================= Coverage 72.63% 72.63% ======================================= Files 28 28 Lines 1889 1889 ======================================= Hits 1372 1372 Misses 381 381 Partials 136 136 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1054/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1054/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.19% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1054/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `45.36% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

perdasilva commented 3 months ago

/lgtm