search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

:seedling: Update certificate code to be more strict #1056

Closed tmshort closed 2 months ago

tmshort commented 2 months ago

Deal with malformed PEM that is skipped by the golang standard library

Description

Reviewer Checklist

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit de53ba8bc26b5ae9dde2c690dbc104c13142171f
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6696d5fe475c980008acf295
Deploy Preview https://deploy-preview-1056--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 74.78261% with 29 lines in your changes missing coverage. Please review.

Project coverage is 73.91%. Comparing base (6e8e035) to head (de53ba8). Report is 2 commits behind head on main.

Files Patch % Lines
internal/httputil/certutil.go 74.78% 14 Missing and 15 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1056 +/- ## ========================================== + Coverage 72.94% 73.91% +0.96% ========================================== Files 28 31 +3 Lines 1889 2028 +139 ========================================== + Hits 1378 1499 +121 - Misses 378 387 +9 - Partials 133 142 +9 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1056/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1056/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.01% <46.95%> (-0.12%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1056/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `49.11% <74.78%> (+2.52%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.