search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

🌱 BundleDeployment Cleanup #1061

Closed dtfranz closed 2 months ago

dtfranz commented 2 months ago

Fixes: #998 Cleans up some of the baggage that came with the BundleDeployment API from rukpak.

Changes:

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 0a8cf9e4a870fae032643b6bb37bf73665d34234
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66984bf2f1487100088aab4e
Deploy Preview https://deploy-preview-1061--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (6cd022e) to head (0a8cf9e). Report is 6 commits behind head on main.

Files Patch % Lines
internal/rukpak/source/unpacker.go 0.00% 9 Missing :warning:
internal/rukpak/source/image_registry.go 60.00% 2 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1061 +/- ## ========================================== + Coverage 72.50% 72.85% +0.34% ========================================== Files 32 31 -1 Lines 1884 1864 -20 ========================================== - Hits 1366 1358 -8 + Misses 383 371 -12 Partials 135 135 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1061/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `55.51% <50.00%> (+0.17%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `45.01% <20.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.