search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
61 stars 53 forks source link

:bug: Revert ":sparkles: Wire up Service Account (#1038)" #1072

Closed joelanford closed 2 months ago

joelanford commented 2 months ago

This reverts commit 95b9f0dc5943497028deb47969310dec45792a2d.

Description

This reverts the #1038, which breaks the standard install of OLMv1.

It appears that the code from #1038 still requires the OLMv1 system service account to have * / * / * permissions (or at least permission to list/watch everything).

The e2e tests from that PR pass because they layer * / * / * permissions back in for both the OLM SA and the ClusterExtension SA, which means that our SA features are essentially untested.

Reviewer Checklist

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit bb4171feb983afaa56539e4ad548a8b5707f159b
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/669a5f69f7ab3400083b9d94
Deploy Preview https://deploy-preview-1072--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

joelanford commented 2 months ago

The "Verify PR title" test is failing because I have an Issue/PR number in the title. In this case, I think it makes sense for the title to reference the PR that we're reverting, so I'm going to ignore that error.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.85%. Comparing base (95b9f0d) to head (bb4171f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1072 +/- ## ========================================== + Coverage 72.59% 72.85% +0.25% ========================================== Files 31 31 Lines 1883 1864 -19 ========================================== - Hits 1367 1358 -9 + Misses 377 371 -6 + Partials 139 135 -4 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1072/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `55.51% <ΓΈ> (-0.68%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/1072/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `45.01% <ΓΈ> (+0.45%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.