operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
55 stars 53 forks source link

⚠ remove olm.bundle.mediatype property and clusterextension support for plain+v0 #822

Closed joelanford closed 5 months ago

joelanford commented 5 months ago

Fixes #822

Description

Reviewer Checklist

netlify[bot] commented 5 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 7a045e1fc066d0291c393cefa94f870b52a01f4b
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6635125755f44f000846fef0
Deploy Preview https://deploy-preview-822--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.86%. Comparing base (5985cce) to head (9748c03). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #822 +/- ## ========================================== + Coverage 64.63% 70.86% +6.22% ========================================== Files 16 16 Lines 1315 1270 -45 ========================================== + Hits 850 900 +50 + Misses 403 300 -103 - Partials 62 70 +8 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/822/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/822/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `41.88% <100.00%> (-0.02%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/822/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `64.01% <100.00%> (+6.29%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

everettraven commented 5 months ago

What do we do with this demo? It seem to rely on plain+v0 bundle types. I think this PR will break the demo.

I'd vote to either:

I personally am leaning towards removal since we are going to need to write new coast-to-coast documentation/tutorials for the new state of the world

joelanford commented 5 months ago

I personally am leaning towards removal

I'll remove it. I was having similar thoughts as well.