Closed m1kola closed 2 months ago
Name | Link |
---|---|
Latest commit | d4884ec6f02ae97901475b722e4672251e2fba01 |
Latest deploy log | https://app.netlify.com/sites/olmv1/deploys/6634cdc7a38523000864b5a2 |
Deploy Preview | https://deploy-preview-827--olmv1.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.63%. Comparing base (
a13a9d8
) to head (d4884ec
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Oh. Does the vertical alignment mess something up?
Oh. Does the vertical alignment mess something up?
Technically - I don't think so. Just suggesting to remove it because it will become visually messy soon since we do not have automation like go fmt
for Makefile
to maintain it. Also this leads to bigger diffs: if you change one line and it changes the alignment - you have to change all the neighbouring lines. Or like in this I just wanted to remove one line and had to make a change to another.
Rebased to fix conflict with https://github.com/operator-framework/operator-controller/pull/798
Good point!
Description
I would prefer if we could avoid formatting like this as it is hard to maintain this style. This also leads to larger diffs: for example, here I wanted to only remove one line but I had to change another for it to not look weird.
Reviewer Checklist