operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
Apache License 2.0
35 stars 49 forks source link

🌱 Remove `Makefile` vertical code alignment #827

Closed m1kola closed 2 months ago

m1kola commented 2 months ago

Description

I would prefer if we could avoid formatting like this as it is hard to maintain this style. This also leads to larger diffs: for example, here I wanted to only remove one line but I had to change another for it to not look weird.

Reviewer Checklist

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit d4884ec6f02ae97901475b722e4672251e2fba01
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6634cdc7a38523000864b5a2
Deploy Preview https://deploy-preview-827--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.63%. Comparing base (a13a9d8) to head (d4884ec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #827 +/- ## ======================================= Coverage 64.63% 64.63% ======================================= Files 16 16 Lines 1315 1315 ======================================= Hits 850 850 Misses 403 403 Partials 62 62 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/827/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/827/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `41.90% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/827/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joelanford commented 2 months ago

Oh. Does the vertical alignment mess something up?

m1kola commented 2 months ago

Oh. Does the vertical alignment mess something up?

Technically - I don't think so. Just suggesting to remove it because it will become visually messy soon since we do not have automation like go fmt for Makefile to maintain it. Also this leads to bigger diffs: if you change one line and it changes the alignment - you have to change all the neighbouring lines. Or like in this I just wanted to remove one line and had to make a change to another.

m1kola commented 2 months ago

Rebased to fix conflict with https://github.com/operator-framework/operator-controller/pull/798

joelanford commented 2 months ago

Good point!