search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
Apache License 2.0
35 stars 49 forks source link

:sparkles: Move helm-operator-plugin #828

Closed tmshort closed 2 months ago

tmshort commented 2 months ago

Description

Reviewer Checklist

tmshort commented 2 months ago

@varshaprasad96 @joelanford This is one thing I missed in the original rukpak. The depedent.go file can also be found here: https://github.com/operator-framework/rukpak/blob/main/internal/helm-operator-plugins/predicate/depedent.go

So, I can do this, and we have duplicate code, or I can made additional changes to rukpak...

joelanford commented 2 months ago

Let's change rukpak. Also, instead of reflect we should use this: https://github.com/kubernetes/apimachinery/blob/37988e577e160bf7749437141fee1d6b8ca15dd6/pkg/api/equality/semantic.go#L28

tmshort commented 2 months ago

@joelanford, I updated rukpak: https://github.com/operator-framework/rukpak/pull/878 But I would consider the reflect changes separate.