operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators

https://operator-framework.github.io/operator-controller/

Apache License 2.0

55 stars 53 forks source link

✨ OPRUN-3293 Fixes several unit tests - not cache ones #831

Closed bentito closed 4 months ago

bentito commented 5 months ago

Description

Fixes several ClusterExtension controller related unit tests. Not ones related to cache not being started though.

Reviewer Checklist

[ ] API Go Documentation
[ ] Tests: Unit Tests (and E2E Tests, if appropriate)
[X] Comprehensive Commit Messages
[ ] Links to related GitHub Issue(s)

bentito commented 5 months ago

Remaining ClusterExtension controller unit test fails should now be limited to:

something messed up in code with "cache not started";
rukpak refs needing to be pulled from test code

tmshort commented 5 months ago

Can you rebase this onto the latest helm-poc branch and fixup? make build and make lint succeed on the helm-poc branch, but not (locally) if this were merged.

tmshort commented 5 months ago

Yeah, you may need to cherry-pick your commit to the updated helm-poc branch... not sure rebase will be smart enough due to the squash.