operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
Apache License 2.0
35 stars 49 forks source link

:bug: Fix shell in Makefile #839

Closed tmshort closed 2 months ago

tmshort commented 2 months ago

Description

Reviewer Checklist

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 06d7d448ee4edcfa10164e9e5bffb2460672ad45
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/663a30b4829c380008d0ce28
Deploy Preview https://deploy-preview-839--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.04%. Comparing base (9bbc444) to head (7d79d65).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #839 +/- ## ======================================= Coverage 71.04% 71.04% ======================================= Files 16 16 Lines 1278 1278 ======================================= Hits 908 908 Misses 300 300 Partials 70 70 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/839/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `42.25% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/839/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `63.59% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmshort commented 2 months ago

TL;DR: The CI was apparently using /bin/sh, and so, non-fatal errors occurred:

/bin/sh: 1: [[: not found
/bin/sh: 1: /home/runner: Permission denied

The SHELL variables was redefined to be bash, but it was done after some $(shell) lines.

grokspawn commented 2 months ago

Noice! I saw those errors this morning and put them on my to-do list, but I wasn't sure where to start.