search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
55 stars 53 forks source link

✨ Add optional field to ClusterExtension API to skip CRD upgrade safety checks #845

Closed rashmigottipati closed 3 months ago

rashmigottipati commented 4 months ago

Description

Adds an optional ClusterExtension.spec.skipCRDUpgradeSafetyChecks field that when set to true will be used to disable the CRD upgrade safety checks when attempting to install a cluster extension.

No logic included in this PR as the CRD Upgrade Safety preflight check as there isn't anything yet to enable/disable. So logic to enable/disable will be added in a future PR once everything is in place.

fixes https://github.com/operator-framework/operator-controller/issues/745

Reviewer Checklist

netlify[bot] commented 4 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit fffc98a0a57f9d860aab3a2347a36bd8edfe28bd
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6643b1c826b7530008dd9348
Deploy Preview https://deploy-preview-845--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 70.05%. Comparing base (e9acbd3) to head (e35ad16).

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 0.00% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #845 +/- ## ========================================== - Coverage 71.02% 70.05% -0.97% ========================================== Files 17 17 Lines 1301 1319 +18 ========================================== Hits 924 924 - Misses 304 322 +18 Partials 73 73 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/845/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `43.36% <0.00%> (-0.60%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `62.66% <0.00%> (-0.93%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

varshaprasad96 commented 4 months ago

Please hold this from merging till #846 gets in. Thanks!

rashmigottipati commented 4 months ago

/hold

openshift-merge-robot commented 3 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
joelanford commented 3 months ago

@rashmigottipati should we close this? Am I correct in assuming that #979 makes this obsolete?

rashmigottipati commented 3 months ago

@joelanford yes, https://github.com/operator-framework/operator-controller/pull/979 makes this obsolete. Will close this