operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
Apache License 2.0
35 stars 49 forks source link

🌱 Update CONTAINER_TOOL evaluation in makefile to warn instead of error #852

Closed everettraven closed 2 months ago

everettraven commented 2 months ago

when unable to find docker or podman as this evaluation results in an error in environments where docker or podman is not installed even when using targets that do not require a container runtime

Description

Reviewer Checklist

netlify[bot] commented 2 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 5130e9064c3ce60a2bf9fe4731bf5c953578eafa
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/664262001d668700087ea28f
Deploy Preview https://deploy-preview-852--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.02%. Comparing base (8e039f3) to head (5130e90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #852 +/- ## ======================================= Coverage 71.02% 71.02% ======================================= Files 17 17 Lines 1301 1301 ======================================= Hits 924 924 Misses 304 304 Partials 73 73 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/852/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `43.96% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/852/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `63.59% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.