Closed everettraven closed 2 months ago
Name | Link |
---|---|
Latest commit | 5130e9064c3ce60a2bf9fe4731bf5c953578eafa |
Latest deploy log | https://app.netlify.com/sites/olmv1/deploys/664262001d668700087ea28f |
Deploy Preview | https://deploy-preview-852--olmv1.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.02%. Comparing base (
8e039f3
) to head (5130e90
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
when unable to find docker or podman as this evaluation results in an error in environments where docker or podman is not installed even when using targets that do not require a container runtime
Description
CONTAINER_TOOL
evaluation logic to warn instead of error out whendocker
orpodman
are not detected in the path. This makes it so that in environments where neither is installed, running targets that don't require a container runtime can still be run. A caveat is that the targets needing a container runtime will still attempt to run and fail. I believe issuing a warning is a good middle ground to provide a clear reason why a target that requires a container runtime would fail, but am open to suggestions on better ways to approach this.Reviewer Checklist