operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

🌱 Makefile, samples: minor cleanup/fixes #866

Closed joelanford closed 1 month ago

joelanford commented 1 month ago

Description

Reviewer Checklist

netlify[bot] commented 1 month ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit a7e83e4b353d5bb4695273b0d2449d0364d0c5e1
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66465f09d278d80008505d40
Deploy Preview https://deploy-preview-866--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci[bot] commented 1 month ago

@skattoju: changing LGTM is restricted to collaborators

In response to [this](https://github.com/operator-framework/operator-controller/pull/866#pullrequestreview-2061719926): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.18%. Comparing base (55c19a1) to head (a7e83e4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #866 +/- ## ======================================= Coverage 83.18% 83.18% ======================================= Files 15 15 Lines 874 874 ======================================= Hits 727 727 Misses 102 102 Partials 45 45 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/866/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/866/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `62.24% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/866/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `74.93% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.