operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
55 stars 53 forks source link

🌱 Helm POC e2e fixes #870

Closed dtfranz closed 4 months ago

dtfranz commented 4 months ago

Fixes the e2e tests in helm-poc branch.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.38%. Comparing base (570b89f) to head (f31a99d).

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 77.14% 5 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## helm-poc #870 +/- ## ============================================ + Coverage 74.87% 75.38% +0.51% ============================================ Files 18 18 Lines 1158 1170 +12 ============================================ + Hits 867 882 +15 + Misses 211 208 -3 Partials 80 80 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/870/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/870/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.06% <73.68%> (+3.65%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/870/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `50.60% <34.21%> (-0.42%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

varshaprasad96 commented 4 months ago

@dtfranz Great work!! all e2e are passing 🎉 !