operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

:sparkles: Address reviews #887

Closed varshaprasad96 closed 1 month ago

varshaprasad96 commented 1 month ago

Description

Reviewer Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.08%. Comparing base (60f4c80) to head (52f37c9).

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## helm-poc #887 +/- ## ============================================ + Coverage 75.38% 76.08% +0.69% ============================================ Files 18 18 Lines 1170 1154 -16 ============================================ - Hits 882 878 -4 + Misses 208 198 -10 + Partials 80 78 -2 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/887/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/887/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.49% <40.00%> (+0.43%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/887/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `51.18% <20.00%> (+0.57%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.