search

operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

🌱 Change global var GetInstalledBundle to interface #899

Closed bentito closed 1 month ago

bentito commented 1 month ago

Description

Follow on to the helm-poc changes:

We'd like to not have a global variable for GetInstalledBundle, but instead an easier to test interface.

Reviewer Checklist

netlify[bot] commented 1 month ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 93b05e0fb47438c6086db26a15265e77aa6f5840
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6658da407ed49e0008c6a218
Deploy Preview https://deploy-preview-899--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.21%. Comparing base (0058054) to head (93b05e0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #899 +/- ## ========================================== - Coverage 77.21% 76.21% -1.01% ========================================== Files 17 17 Lines 1176 1177 +1 ========================================== - Hits 908 897 -11 - Misses 189 202 +13 + Partials 79 78 -1 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/899/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/899/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `58.19% <100.00%> (-1.67%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/899/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `58.02% <50.00%> (-0.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.