operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

Meta: Helm Integration follow ups #903

Open varshaprasad96 opened 1 month ago

varshaprasad96 commented 1 month ago

This issue tracks the follow ups which are in queue after the helm integration feature is merged to main: #846

Codebase:

Tests:

Moved to #733

joelanford commented 2 weeks ago

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

I added an item to the checklist in the description (#942)

tmshort commented 6 days ago

@joelanford should this be considered an epic, in place of or addition to #733?