search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
54 stars 53 forks source link

:sparkles: Update status update functions #908

Closed tmshort closed 3 months ago

tmshort commented 4 months ago

Remove references to rukpak k8s API where possible.

With the removal of Extension, the status update functions no longer need to be generic. Simplify the function signatures

This also makes the update functions consistent signature/behavior.

Description

Reviewer Checklist

netlify[bot] commented 4 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit c0a1193218c66b20b471fd5d7b98a267acff57d8
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/665f551e436fe8000844eaf1
Deploy Preview https://deploy-preview-908--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 56.66667% with 39 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (841db34) to head (c0a1193). Report is 2 commits behind head on main.

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 35.48% 20 Missing :warning:
internal/controllers/common_controller.go 64.81% 19 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #908 +/- ## ========================================== - Coverage 77.93% 77.77% -0.16% ========================================== Files 17 17 Lines 1142 1152 +10 ========================================== + Hits 890 896 +6 - Misses 175 179 +4 Partials 77 77 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/908/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `59.80% <50.00%> (+<0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `60.04% <42.22%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bentito commented 3 months ago

/lgtm /approve