search

operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

:warning: Update to go 1.22 #909

Closed tmshort closed 1 month ago

tmshort commented 1 month ago

Fix issues with the extension-developer-e2e and operator-sdk

Description

Reviewer Checklist

netlify[bot] commented 1 month ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 8eba808138e6c8fbde6e02d8c48cc73dfd8d2600
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66606f3a30080a0008123f8f
Deploy Preview https://deploy-preview-909--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.49%. Comparing base (396d978) to head (2dcf6ca).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #909 +/- ## ========================================== - Coverage 78.19% 73.49% -4.70% ========================================== Files 17 18 +1 Lines 1142 1215 +73 ========================================== Hits 893 893 - Misses 173 246 +73 Partials 76 76 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `60.07% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `48.06% <ΓΈ> (-12.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

varshaprasad96 commented 1 month ago

@tmshort the last commit in this PR was trying to do the same, without bumping go for now.

We are bumping controller-gen for generating oc manifests here, but keeping controller-runtime and other related deps like helm-operator plugins the same. Its better to keep them tied together, so we can either bump it all in this or do an immediate follow up for the same?

tmshort commented 1 month ago

Bumping things like operator-controller, etc, creates an avalanche of other changes. To get things completed and done faster (i.e. reviews), it's easier to do smaller, incremental changes. We'll get there, it's just doing it in one big chunk is probably not a good idea.

tmshort commented 1 month ago

@tmshort the last commit in this PR was trying to do the same, without bumping go for now.

We're still having trouble updating rukpak... that change is quite big, and should be done "as it's own thing". If we can make that PR simpler by doing some of that work here, so much the better.

tmshort commented 1 month ago

The executable for controller-gen has been updated consistently, so we're not running different versions of the same tool.