search

operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

⚠️ Only allow bundles with `AllNamespaces` install mode #924

Closed m1kola closed 3 weeks ago

m1kola commented 3 weeks ago

Description

TBD

Closes #816

Reviewer Checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 90be17c64b27f1acf892a237bd2f8c192c616239
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66699ce7fbe9500008a77eec
Deploy Preview https://deploy-preview-924--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.38%. Comparing base (66a063b) to head (90be17c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #924 +/- ## ======================================= Coverage 77.38% 77.38% ======================================= Files 17 17 Lines 1163 1163 ======================================= Hits 900 900 Misses 183 183 Partials 80 80 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.17% <100.00%> (ø)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `50.98% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m1kola commented 3 weeks ago

Closing as obsolete: we no longer need this fix #928. Also as discussed in https://github.com/operator-framework/operator-controller/pull/924#discussion_r1636479158 we do not want to double test.