search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
54 stars 53 forks source link

✨ Cleanups after bumping Rukpak #928

Closed varshaprasad96 closed 3 months ago

varshaprasad96 commented 3 months ago

This PR makes the following changes:

  1. Removes the use of a separate handler, given rukpak has now externalized its implementation.
  2. Removes the unpacking status, which is no longer required with the use of direct registry client.

Description

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 3fa711f9ac986a0269cf500c62b8b6a495076070
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666a9573adc35f00087257fb
Deploy Preview https://deploy-preview-928--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.15%. Comparing base (543dc15) to head (3fa711f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #928 +/- ## ========================================== + Coverage 77.45% 79.15% +1.70% ========================================== Files 17 15 -2 Lines 1153 1084 -69 ========================================== - Hits 893 858 -35 + Misses 181 157 -24 + Partials 79 69 -10 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/928/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.19% <100.00%> (+0.38%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.70% <33.33%> (+3.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

varshaprasad96 commented 3 months ago

Looks like https://github.com/operator-framework/operator-controller/pull/916 is causing merge conflicts when added to the queue. Will rebase this after #916 gets merged.

bentito commented 3 months ago

/lgtm