search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
54 stars 53 forks source link

:bug: Revert "Move the e2e into the operator-controler-system ns" #930

Closed tmshort closed 3 months ago

tmshort commented 3 months ago

This ends up overwriting the security policy of the operator-controller-system namespace, which really isn't something we want to do in a valid e2e test.

Many of the e2e components need to run as root in order to do the things they need to do.

This reverts commit aa48e704bbbc4ae808fff5e3d762f95df3a0982a.

Description

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit c0eaa42b896c69c63e03b40e702462845abd8b65
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666afdccb9aa9d00088656a2
Deploy Preview https://deploy-preview-930--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.15%. Comparing base (8041cc4) to head (c0eaa42).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #930 +/- ## ======================================= Coverage 79.15% 79.15% ======================================= Files 15 15 Lines 1084 1084 ======================================= Hits 858 858 Misses 157 157 Partials 69 69 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/930/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.19% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/930/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.70% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmshort commented 3 months ago

Revert of #927