operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

:sparkles: Use apimachinery sets instead of maps #933

Closed itroyano closed 3 weeks ago

itroyano commented 3 weeks ago

Description

Fixes #881

Reviewer Checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 2e2e85ebae99477f86f0b4e7d8300e6281d5b602
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666b33004250f100083d70da
Deploy Preview https://deploy-preview-933--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.61%. Comparing base (8041cc4) to head (2e2e85e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #933 +/- ## ========================================== + Coverage 79.15% 79.61% +0.46% ========================================== Files 15 15 Lines 1084 1084 ========================================== + Hits 858 863 +5 + Misses 157 154 -3 + Partials 69 67 -2 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/933/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.65% <100.00%> (+0.46%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.70% <0.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.