search

operator-framework / operator-controller

Apache License 2.0
29 stars 47 forks source link

πŸ› Fix rbac generation in `Makefile` #937

Closed m1kola closed 3 weeks ago

m1kola commented 3 weeks ago

Description

It looks like #888 we moved rbac manifests, but did not update controller-gen output path. This PR should fix this.

Reviewer Checklist

netlify[bot] commented 3 weeks ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 0cc37997d5e5bd7d6ac06d0af0c3a2c11b69eddf
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666c5074abee1c00089c3152
Deploy Preview https://deploy-preview-937--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

trgeiger commented 3 weeks ago

Thanks for catching this, LGTM

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.16%. Comparing base (edc91ad) to head (0cc3799).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #937 +/- ## ========================================== - Coverage 79.34% 79.16% -0.19% ========================================== Files 16 16 Lines 1104 1104 ========================================== - Hits 876 874 -2 - Misses 158 159 +1 - Partials 70 71 +1 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.60% <ΓΈ> (-0.55%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.71% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

grokspawn commented 3 weeks ago

should we also .gitignore config/rbac since it is generated?

m1kola commented 3 weeks ago

@grokspawn nothing should write into config/rbac anymore. Not sure that ignoring it makes a lot of sense.

grokspawn commented 3 weeks ago

@grokspawn nothing should write into config/rbac anymore. Not sure that ignoring it makes a lot of sense.

Ah! I had leftover artifacts there after running the test for you this morning, and presumed that path was still used. If vestigial, ignore!