search

operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
54 stars 53 forks source link

✨ remove unnecessary flag, optimize catalog watch handler, stop watching non-existent unpack pods #941

Closed joelanford closed 3 months ago

joelanford commented 3 months ago

Description

Reviewer Checklist

netlify[bot] commented 3 months ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 3b172c3fee9fdf427b22dd8f4d8017acd70d1efe
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/666d9ade619dfe000826edff
Deploy Preview https://deploy-preview-941--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (f301f55) to head (3b172c3).

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 62.50% 5 Missing and 1 partial :warning:
cmd/manager/main.go 89.47% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #941 +/- ## ========================================== + Coverage 79.34% 80.41% +1.06% ========================================== Files 16 16 Lines 1104 1103 -1 ========================================== + Hits 876 887 +11 + Misses 158 150 -8 + Partials 70 66 -4 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/941/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `59.20% <81.48%> (+1.05%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/941/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.85% <1.85%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmshort commented 3 months ago

Looks like 'make verify' or equivalent is needed. /hold

joelanford commented 3 months ago

Oops forgot to re-gen RBAC. Will do!

joelanford commented 3 months ago

/hold cancel