operator-framework / operator-controller

A new and improved management framework for extending Kubernetes with Operators
https://operator-framework.github.io/operator-controller/
Apache License 2.0
54 stars 53 forks source link

Fix: finalizers not set on ClusterExtension #942

Closed joelanford closed 3 months ago

joelanford commented 3 months ago

Another thing I just found. We setup finalizers in main.go, but then don't actually set them on the reconciler or call Finalize during reconciliation. I tried updating to do these things, but then the controller started panic-ing because the finalizer expects to finalize a BundleDeployment, but we are now trying to finalize a ClusterExtension.

Originally posted by @joelanford in https://github.com/operator-framework/operator-controller/issues/903#issuecomment-2168585196

joelanford commented 3 months ago

This was fixed by #941