search

operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

🌱 Remove E2E test testing rukpak #946

Closed m1kola closed 2 weeks ago

m1kola commented 2 weeks ago

Description

We use rukpak as a library at the moment and want rukpak to have own tests covering limitations such not allowing to install content with webhooks.

This is a follow up for this discussion: https://github.com/operator-framework/operator-controller/pull/924#discussion_r1636479158

Added extra coverage for rukpak: https://github.com/operator-framework/rukpak/pull/922

Reviewer Checklist

netlify[bot] commented 2 weeks ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 74297c3e13f67313ec9a5e5d53baff75243547ce
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66705bef231d1100083648ae
Deploy Preview https://deploy-preview-946--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.96%. Comparing base (b4c928c) to head (74297c3). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #946 +/- ## ========================================== - Coverage 80.41% 79.96% -0.46% ========================================== Files 16 16 Lines 1103 1103 ========================================== - Hits 887 882 -5 - Misses 150 153 +3 - Partials 66 68 +2 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/946/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.66% <ΓΈ> (-1.55%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `53.85% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m1kola commented 2 weeks ago

Something wrong with code coverage report: it dropped to 0 for e2e tests. Even cmd/manager/main.go doesn't have any coverage which is clearly not the case because we run other E2E tests.

m1kola commented 2 weeks ago

Something wrong with code coverage report: it dropped to 0 for e2e tests. Even cmd/manager/main.go doesn't have any coverage which is clearly not the case because we run other E2E tests.

No longer can reproduce after rebased on top of main.