search

operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

:sparkles: Certificate support for image registry #956

Closed tmshort closed 1 week ago

tmshort commented 2 weeks ago

Updates the ClusterExtension API to support a certificate to retreive a bundle from an image registry.

Fixes #921

Description

Reviewer Checklist

netlify[bot] commented 2 weeks ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit c210e8583efa494ed86bd7a347d17e0821e8e636
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6671aca079e1040008a3eb29
Deploy Preview https://deploy-preview-956--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 57.89474% with 24 lines in your changes missing coverage. Please review.

Project coverage is 79.07%. Comparing base (bfd4142) to head (c210e85).

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 44.00% 14 Missing :warning:
...nternal/controllers/clusterextension_controller.go 67.74% 5 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #956 +/- ## ========================================== - Coverage 80.14% 79.07% -1.07% ========================================== Files 16 16 Lines 1103 1152 +49 ========================================== + Hits 884 911 +27 - Misses 152 169 +17 - Partials 67 72 +5 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/956/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.55% <52.63%> (-0.66%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `51.90% <14.03%> (-1.95%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tmshort commented 1 week ago

See #960 for a different approach