search

operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

🐛 fix: remove unnecessary bundle cache volume #964

Closed joelanford closed 1 week ago

joelanford commented 1 week ago

Description

When I removed the flag that controlled the bundle cache root directory in #941, I missed the fact that we also had a volumeMount for it, which is a child of our broader /var/cache volume emptyDir volume.

This commit eliminates the unnecessary extra volume and instead just creates the /var/cache/bundles directory in the existing volume.

This is important to eliminate the potential for issues when attempting to rename files across filesystem boundaries using os.Rename (e.g. if we ever needed to do something like rename /var/cache/tmp/foobar.txt to /var/cache/bundles/foobar.txt)

Reviewer Checklist

netlify[bot] commented 1 week ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit f2f8862df3f207d0e33992652279384be422784b
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66759fcd79e1040008ccc9c2
Deploy Preview https://deploy-preview-964--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.