search

operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

:bug: Fixing the labels for better metrics collection #969

Open LalatenduMohanty opened 1 week ago

LalatenduMohanty commented 1 week ago

As the label selector used for both catalogd and operator-controller metrics services is "control-plane: controller-manager". Hence changing the labels in both operator-controller and catalogd to make sure we do not overlap.

Description

Reviewer Checklist

netlify[bot] commented 1 week ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit 849312b883b57880210ffadf6c246ed63c9e62ab
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/667a01632783f00008ee1571
Deploy Preview https://deploy-preview-969--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.40%. Comparing base (2eca31d) to head (849312b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #969 +/- ## ======================================= Coverage 79.40% 79.40% ======================================= Files 17 17 Lines 1170 1170 ======================================= Hits 929 929 Misses 165 165 Partials 76 76 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/969/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Ξ” | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/969/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `57.35% <ΓΈ> (ΓΈ)` | | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/969/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `54.44% <ΓΈ> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.