operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

✨ Add CRD Upgrade Safety Preflight check to the ClusterExtension controller #979

Closed rashmigottipati closed 5 days ago

rashmigottipati commented 1 week ago

Description

Fixes https://github.com/operator-framework/operator-controller/issues/877

Reviewer Checklist

netlify[bot] commented 1 week ago

Deploy Preview for olmv1 failed.

Name Link
Latest commit d84277f1d310b7d8de91a1316d9422160b743ca0
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/667dc85eef573d000864b99b
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 26.98413% with 46 lines in your changes missing coverage. Please review.

Project coverage is 76.89%. Comparing base (208e584) to head (06914d2).

Files Patch % Lines
api/v1alpha1/zz_generated.deepcopy.go 4.00% 23 Missing and 1 partial :warning:
...nternal/controllers/clusterextension_controller.go 38.70% 15 Missing and 4 partials :warning:
cmd/manager/main.go 57.14% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #979 +/- ## ========================================== - Coverage 79.40% 76.89% -2.51% ========================================== Files 17 17 Lines 1170 1225 +55 ========================================== + Hits 929 942 +13 - Misses 165 201 +36 - Partials 76 82 +6 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/979/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/979/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.23% <26.98%> (-1.56%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/979/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `52.00% <0.00%> (-2.45%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.