Closed m1kola closed 4 days ago
Name | Link |
---|---|
Latest commit | d1bda18aeba8d2347fcb9a5cc91643fed5dee9e1 |
Latest deploy log | https://app.netlify.com/sites/olmv1/deploys/667eb2afa90d6a00086bfb8e |
Deploy Preview | https://deploy-preview-990--olmv1.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 77.19%. Comparing base (
cab41aa
) to head (d1bda18
).
Files | Patch % | Lines |
---|---|---|
...nternal/controllers/clusterextension_controller.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
go-apidiff is expected to fail because I'm chasing the API here.
/lgtm
Description
Closes #989 by removing the condition and solves an E2E flake.
Note: in this brief were are revisiting
ClusterExtension
conditions and their reasons. One of the points is about removal ofHasValidBundle
condition type.The brief is still in review, but I would like to move forward with this change as it resolves a flake I hit regularly (especially locally).
Reviewer Checklist