operator-framework / operator-controller

Apache License 2.0
28 stars 47 forks source link

⚠️ Remove `HasValidBundle` condition #990

Closed m1kola closed 4 days ago

m1kola commented 4 days ago

Description

Closes #989 by removing the condition and solves an E2E flake.

Note: in this brief were are revisiting ClusterExtension conditions and their reasons. One of the points is about removal of HasValidBundle condition type.

The brief is still in review, but I would like to move forward with this change as it resolves a flake I hit regularly (especially locally).

Reviewer Checklist

netlify[bot] commented 4 days ago

Deploy Preview for olmv1 ready!

Name Link
Latest commit d1bda18aeba8d2347fcb9a5cc91643fed5dee9e1
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/667eb2afa90d6a00086bfb8e
Deploy Preview https://deploy-preview-990--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.19%. Comparing base (cab41aa) to head (d1bda18).

Files Patch % Lines
...nternal/controllers/clusterextension_controller.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #990 +/- ## ========================================== + Coverage 76.89% 77.19% +0.29% ========================================== Files 17 17 Lines 1225 1206 -19 ========================================== - Hits 942 931 -11 + Misses 201 193 -8 Partials 82 82 ``` | [Flag](https://app.codecov.io/gh/operator-framework/operator-controller/pull/990/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/operator-framework/operator-controller/pull/990/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `56.96% <0.00%> (+0.72%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/operator-framework/operator-controller/pull/990/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework) | `51.90% <0.00%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=operator-framework#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

m1kola commented 4 days ago

go-apidiff is expected to fail because I'm chasing the API here.

bentito commented 4 days ago

/lgtm