search

operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

Add validations for customresourcedefinitions and apiservicedefinitions #112

Open darkowlzz opened 5 years ago

darkowlzz commented 5 years ago

Adds _csv_crd_validation() and _csv_asd_validation for validating csv.spec.customresourcedefinitions and csv.spec.apiservicedefinitions respectively. Also validates the descriptors in both CRD and ASD using a common method _csv_descriptors_validation().

openshift-ci-robot commented 5 years ago

Hi @darkowlzz. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
flickerfly commented 4 years ago

/test

Because I'm interested in this work and it has been awhile.

openshift-ci-robot commented 3 years ago

@darkowlzz: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.