search

operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

Remove SemVer requirement for nested version folders for flatten command #118

Closed jeremy-wl closed 5 years ago

jeremy-wl commented 5 years ago

This PR solves similar problem of https://github.com/operator-framework/operator-courier/pull/116, where we do not strictly require the version folder name to be a SemVer.

However, we still need the SemVer of the directory in order to compare and retrieve the latest version of each CRD from each version folder. We get this SemVer by first parsing the spec.version field in CSV of each folder.

jeremy-wl commented 5 years ago

/cc @kevinrizza @MartinBasti

ralphbean commented 5 years ago

Any progress on this one @jeremylinlin - @shawn-hurley's build is blocked on this and we'd like to be able to get it to QE.

jeremy-wl commented 5 years ago

Hi @ralphbean, sorry for the delay. I have just updated the PR @kevinrizza.

kevinrizza commented 5 years ago

lgtm aside from Martin's one comment

csomh commented 5 years ago

:heavy_check_mark: flattening and pushing the manifests from the blocked build works with this patch.