Ignore extra files in manifest dir

operator-framework / operator-courier

Build, verify and push operators

Apache License 2.0

41 stars 53 forks source link

Ignore extra files in manifest dir #137

Closed kevinrizza closed 5 years ago

kevinrizza commented 5 years ago

Update the identifier to return empty string when parsing unexpected file (i.e. non csv/crd/package)
Update callers to ignore file when filetype returned is none
Update tests to reflect this change

MartinBasti commented 5 years ago

@kevinrizza tests fail

kevinrizza commented 5 years ago

Great work Kevin, although I do have one concern - it seems like only the CRDs, CSVs, and Packages will be placed in the zip that is pushed to Quay. Should the yamls that OLM supports be pushed as well?

Seems like it would be extremely difficult to keep these in sync. In that case, it might just be easier for us to bundle any yaml file that we find in the directory.

kevinrizza commented 5 years ago

@awgreene @MartinBasti Please take another look, I updated the identify method to include a new result identify.UNKNOWN_FILE that will be the result for any valid yaml file that isn't specifically one of the supported manifests.

I am going to create a followup pr to include the other OLM types that we need to support.

kevinrizza commented 5 years ago

Closing this pr in favor of https://github.com/operator-framework/operator-courier/pull/141 due to an issue with the CI configuration in Travis