search

operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

Add validation details into raised exception #147

Closed MartinBasti closed 5 years ago

MartinBasti commented 5 years ago

When manifests are invalid operator courier should provide details about errors.

Fixes: #146

Signed-off-by: Martin Bašti mbasti@redhat.com

kevinrizza commented 5 years ago

/lgtm

MartinBasti commented 5 years ago

Test failure seems unrelated to my PR

MartinBasti commented 5 years ago

Is there anything missing that prevents PR from being merged?

kevinrizza commented 5 years ago

@MartinBasti The build error does seem unrelated at first glance to your change, but master is currently succeeding and this pr is reproducibly failing. At the moment the holdup is just that I don't have the bandwidth to triage what's causing it and get it working unfortunately. I would rather not accidentally introduce a breaking change, especially if it's just for a quality of life feature.

If you have some time to figure out why the build is breaking then I would be happy to merge it.

MartinBasti commented 5 years ago

I re-ran master jobs, it is failing there too. https://travis-ci.org/operator-framework/operator-courier/jobs/549733746

So as I said, error is unrelated to my PR.

I don't have macos knowledge and resources to fix that issue

kevinrizza commented 5 years ago

I re-ran master jobs, it is failing there too. https://travis-ci.org/operator-framework/operator-courier/jobs/549733746

So as I said, error is unrelated to my PR.

I don't have macos knowledge and resources to fix that issue

Yeah, I didn't expect it to be. But again like I said I don't have the bandwidth either unfortunately. If there is specific traction from PM to get something like this merged we can do so, otherwise it will have to wait at least until I have free cycles to look at it.