operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

CVS Version field is not verified #159

Open cmoulliard opened 5 years ago

cmoulliard commented 5 years ago

Issue

When a CSV file contains a .spec.version field which contains letters like this this v1.0.0, then the operatorhub will not be able to install the packagemanifest.

The operator created to download from quay the catalog of our bundle reports that the catalog was not loaded

namespace: openshift-marketplace
pod: halkyon-operators-5695ccb997-j2rj8
time="2019-08-28T13:50:51Z" level=info msg="Using in-cluster kube client config" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="operator source(s) specified are - [https://quay.io/cnr%7Chalkyonio]" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="package(s) specified are - halkyon" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="input has been sanitized" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="sources: [https://quay.io/cnr/halkyonio]" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="packages: [halkyon]" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="the following packages could not be resolved: map[halkyon:false]" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="resolved the following packages: []" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="download complete - 0 repositories have been downloaded" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="decoding the downloaded operator manifest(s)" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="decoded 0 flattened and 0 nested operator manifest(s)" port=50051 type=appregistry
time="2019-08-28T13:50:51Z" level=info msg="serving registry" port=50051 type=appregistry

and the status mentions

reason: Error
          message: >
            time="2019-08-28T13:48:09Z" level=fatal msg="error loading manifest
            from remote registry - strconv.ParseInt: parsing \"v0\": invalid
            syntax" port=50051 type=appregistry

It should then great that such error is checked by operator-courier verify step.