search

operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

Error reporting #66

Closed chmeliik closed 5 years ago

openshift-ci-robot commented 5 years ago

Hi @chmeliik. Thanks for your PR.

I'm waiting for a operator-framework or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
MartinBasti commented 5 years ago

@chmeliik Good job, I had just minor comments! Let's wait for owners if they agree with such changes :-)

MartinBasti commented 5 years ago

Maybe public API methods should also have documented which exceptions they raise.

chmeliik commented 5 years ago

Updated PR, cc @kevinrizza @MartinBasti @awgreene

kevinrizza commented 5 years ago

@chmeliik Can you please squash your commits?

chmeliik commented 5 years ago

@kevinrizza Can do, do you want all the changes in a single commit?

kevinrizza commented 5 years ago

@kevinrizza Can do, do you want all the changes in a single commit?

@chmeliik Yes please.

chmeliik commented 5 years ago

Added specific Quay errors, cc @kevinrizza @MartinBasti @awgreene

kevinrizza commented 5 years ago

/lgtm

chmeliik commented 5 years ago

Updated PR. Had to change the exception hierarchy a bit to allow for an exception that would inherit from the base exception but not from ValueError. Added a couple simple tests to make sure I didn't mess it up. cc @MartinBasti @kevinrizza

kevinrizza commented 5 years ago

/lgtm

openshift-ci-robot commented 5 years ago

New changes are detected. LGTM label has been removed.

chmeliik commented 5 years ago

Rebased on master