search

operator-framework / operator-courier

Build, verify and push operators
Apache License 2.0
41 stars 53 forks source link

Update Travis CI config to test courier on macOS #70

Closed jeremy-wl closed 5 years ago

jeremy-wl commented 5 years ago

Build operator-courier on macOS with Travis CI.

Because testing Python projects on macOS is not natively supported by Travis CI, I use a workaround to make it happen. Finishing tests on macOS with Travis CI will take around 10min, due to the time-consuming brew update and brew install operations.

MartinBasti commented 5 years ago

What are we trying here? I haven't noticed any platform dependent code in operator-courier

EDIT: got it, related to #64

jeremy-wl commented 5 years ago

@MartinBasti See https://github.com/operator-framework/operator-courier/pull/64. I'm updating the travis ci config to run on macOS to make sure courier works on that platform as well.

MartinBasti commented 5 years ago

Do we use any platform specific python modules? Will we test windows too?

jeremy-wl commented 5 years ago

@MartinBasti @kevinrizza

Do we use any platform specific python modules?

Maybe not for now.

Will we test windows too?

Based on our discussion today, we will support courier on macOS but not Windows.

jeremy-wl commented 5 years ago

/cc @awgreene @kevinrizza @SamiSousa

kevinrizza commented 5 years ago

/lgtm

csomh commented 5 years ago

This will make Travis builds to be 5 to 10 times slower (1-2 minutes vs 10+ minutes), and as such delay feedback for devs.

As @MartinBasti pointed out, there is no platform specific code in operator-courier, so I'm not sure about the value of running the tests on Mac.

kevinrizza commented 5 years ago

@csomh @MartinBasti You are right, today we do not have any platform specific code. But that doesn't guarantee that we won't have some committed in the future, especially given that the CLI does filesystem modification (take a look at the nest command as an example).

Furthermore, 10+ minutes is not an enormous change, given that code review should take more than an order of magnitude longer than that.