operator-framework / operator-lifecycle-manager

A management framework for extending Kubernetes with Operators
https://olm.operatorframework.io
Apache License 2.0
1.7k stars 542 forks source link

InstallPlan approval is Manual when create subscription with Automatic Approval Strategy #1859

Open DanielXLee opened 3 years ago

DanielXLee commented 3 years ago

Bug Report

What did you do?

  1. Install etcd operator with Manual Approval Strategy in namespace default
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: etcd
  namespace: default
spec:
  channel: singlenamespace-alpha
  installPlanApproval: Manual
  name: etcd
  source: community-operators
  sourceNamespace: openshift-marketplace
  1. Install jenkins-operator with Automatic Approval Strategy in namespace default
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  name: jenkins-operator
  namespace: default
spec:
  channel: alpha
  installPlanApproval: Automatic
  name: jenkins-operator
  source: community-operators
  sourceNamespace: openshift-marketplace

But I found the InstallPlan install-wchdm for jenkins-operator approval is Manual

# oc get ip -n default
NAME            CSV                      APPROVAL   APPROVED
install-mvwsg   etcdoperator.v0.9.4      Manual     true
install-wchdm   jenkins-operator.0.6.0   Manual     false

What did you expect to see? I want to see InstallPlan install-wchdm for jenkins-operator approval is Automatic

What did you see instead? Under which circumstances? Test result is Manual.

I don't know if this is design or issue.

Environment

Possible Solution

Additional context Add any other context about the problem here.

zkyle95 commented 3 years ago

Probably caused by this? Seems like the developer had realized the problem.

https://github.com/operator-framework/operator-lifecycle-manager/blob/v0.17.0/pkg/controller/operators/catalog/operator.go#L904

DanielXLee commented 3 years ago

@zkyle95 Thanks for your quick response, I want to know, is this design or issue? If this is design behavior, do we have some docs describe this behavior.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.